Emit llvm.amdgcn.update.dpp for both __builtin_amdgcn_mov_dpp and
__builtin_amdgcn_update_dpp. The second last argument to
llvm.amdgcn.update.dpp will be undef for __builtin_amdgcn_mov_dpp.
Details
Details
Diff Detail
Diff Detail
- Repository
- rC Clang
Event Timeline
lib/CodeGen/CGBuiltin.cpp | ||
---|---|---|
11313–11315 | The only difference between this and mov_dpp is the argument count and the intrinsic ID, so you can combine the cases |
lib/CodeGen/CGBuiltin.cpp | ||
---|---|---|
11313–11315 | We should really drop mov_dpp. It will be easier to do so if we keep the cases separate. |
lib/CodeGen/CGBuiltin.cpp | ||
---|---|---|
11313–11315 | We could also emit the mov_dpp with the new intrinsic, using I think undef for the extra operand? |
Comment Actions
Brian checked the extra argument for dpp mov should be the first one. so mov_dpp(x,...) --> update_dpp(undef, x, ...). I will fix that when committing.
The only difference between this and mov_dpp is the argument count and the intrinsic ID, so you can combine the cases