Defer unnecessary early inlining of constants to symbol
variants. Fixes PR38945.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
- Build Status
Buildable 22740 Build 22740: arc lint + arc unit
Event Timeline
llvm/lib/MC/MCParser/AsmParser.cpp | ||
---|---|---|
1128 | I'm not super enthused about relying on the enum's value being zero as opposed to checking that Variant == MCSymbolRefExpr::VK_None, but it looks like it's done so anyways on L1132, so I guess it's fine. | |
llvm/test/MC/PowerPC/pr38945.s | ||
9 | Can you add a test for the - prefix for negating the number, too (assuming it works and doesn't need additional code changed)? ie cmpwi 8,(-NUMBER)@l cmpwi 8,-NUMBER@l |
I'm not super enthused about relying on the enum's value being zero as opposed to checking that Variant == MCSymbolRefExpr::VK_None, but it looks like it's done so anyways on L1132, so I guess it's fine.