Page MenuHomePhabricator

[llvm-objcopy] Change --only-keep to --only-sections
ClosedPublic

Authored by jakehehrlich on Sep 17 2018, 11:22 AM.

Details

Summary

I just hard core goofed when I wrote this and created a different name for no good reason. I'm failry aware of most "fresh" users of llvm-objcopy (that is, users which are not using it as a drop in replacement for GNU objcopy) and can say that only "-j" is being used by such people so this patch should strictly increase compatibility and not remove it.

Diff Detail

Repository
rL LLVM

Event Timeline

jakehehrlich created this revision.Sep 17 2018, 11:22 AM
alexshap accepted this revision.Sep 17 2018, 12:41 PM
This revision is now accepted and ready to land.Sep 17 2018, 12:41 PM
rupprecht requested changes to this revision.Sep 17 2018, 12:46 PM

The GNU objcopy name is only-section, not only-sections (note singular vs plural)
But otherwise LGTM :)

This revision now requires changes to proceed.Sep 17 2018, 12:46 PM

Who put me in charge of this? I'm clearly unqualified.

Who put me in charge of this? I'm clearly unqualified.

Don't worry - I reviwed it (I think) and still missed it :/

Alex - any update on this?

Rebased and used -only-section (no s at the end)

rupprecht accepted this revision.Dec 5 2018, 4:18 PM

Thanks!

This revision is now accepted and ready to land.Dec 5 2018, 4:18 PM
This revision was automatically updated to reflect the committed changes.