This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Handle V128RegClass in more places
AbandonedPublic

Authored by tlively on Sep 14 2018, 11:11 AM.

Details

Reviewers
aheejin
dschuff
Summary

Adds logic to handle V128RegClass wherever possible. It is still not
handled in selectSelect in WebAssemblyFastISel, but there is no v128
select, so that would be more complicated anyway.

Diff Detail

Event Timeline

tlively created this revision.Sep 14 2018, 11:11 AM

Are there tests that trigger these? It might make sense to add a case at least to the explicit locals and reg stackify. Probably fast-isel support should be a separate change (you can take the existing SIMD tests and run the same test, forcing fast-isel as some of the other tests do)

aheejin added inline comments.Sep 19 2018, 11:28 AM
lib/Target/WebAssembly/WebAssemblyRegStackify.cpp
123

Do we have a test for this?

tlively planned changes to this revision.Sep 21 2018, 6:00 PM

Needs to be split up and tested.

tlively abandoned this revision.Nov 6 2018, 10:19 AM