Page MenuHomePhabricator

[Sema] Do not load macros from preamble when LoadExternal is false.
ClosedPublic

Authored by ioeric on Sep 14 2018, 1:20 AM.

Diff Detail

Repository
rC Clang

Event Timeline

ioeric created this revision.Sep 14 2018, 1:20 AM

Maybe add a test?
There is test/Index/complete-pch-skip.cpp that checks similar things for AST completions, adding macros there should be trivial.

ioeric updated this revision to Diff 165969.Sep 18 2018, 7:14 AM
  • added lit test
This revision is now accepted and ready to land.Sep 19 2018, 2:03 AM
This revision was automatically updated to reflect the committed changes.
nik added a subscriber: nik.Jul 17 2019, 3:28 AM

I've bisected https://bugs.llvm.org/show_bug.cgi?id=42649 to this change. Reverting this change fixes the issue.

Please look into it.

Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2019, 3:28 AM
Herald added a subscriber: arphaman. · View Herald Transcript