[Driver] Fix missing MultiArch include dir on powerpcspe
ClosedPublic

Authored by glaubitz on Sep 13 2018, 6:20 PM.

Details

Summary

On powerpc-linux-gnuspe, the header files are located in their
own include directory named /usr/lib/powerpc-linux-gnuspe,
so add this directory to PPCMultiarchIncludeDirs.

Diff Detail

Repository
rL LLVM
glaubitz created this revision.Sep 13 2018, 6:20 PM

I don't have commit access, btw. So it would be nice if someone else could commit this for me.

Thanks!

kristina accepted this revision.Sep 14 2018, 5:31 AM

LGTM.

In the future please make sure you supply all patches with context (ie. -U99999), without context they may be harder to review and more importantly patch may mess up.

This revision is now accepted and ready to land.Sep 14 2018, 5:31 AM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.
lebedev.ri added inline comments.
cfe/trunk/lib/Driver/ToolChains/Linux.cpp
701

This is probably missing test coverage?
It seems, some of these are tested, but not all:

clang/test$ find -iname include | grep tree | wc -l
112

Not sure how this is supposed to be tested as this requires a proper Debian powerpcspe chroot.

I also checked saw that not all mips64 include paths are covered by the testsuite.