This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis][NFC] Split BenchmarkRunner class
ClosedPublic

Authored by courbet on Sep 12 2018, 5:13 AM.

Details

Summary

The snippet-generation part goes to the SnippetGenerator class.

This will allow benchmarking arbitrary code (see PR38437).

Diff Detail

Event Timeline

courbet created this revision.Sep 12 2018, 5:13 AM
courbet updated this revision to Diff 165068.Sep 12 2018, 5:13 AM

clang-format

Harbormaster completed remote builds in B22535: Diff 165068.
courbet updated this revision to Diff 165069.Sep 12 2018, 5:16 AM

update comment

gchatelet accepted this revision.Sep 12 2018, 1:02 PM
gchatelet added inline comments.
tools/llvm-exegesis/lib/SnippetGenerator.h
41

SnippetGeneratorBase?

This revision is now accepted and ready to land.Sep 12 2018, 1:02 PM

Thanks.

tools/llvm-exegesis/lib/SnippetGenerator.h
41

Users of the class manipulate it through the base class, so it would be a bit awkward to have functions take a SnippetGeneratorBase instead of a SnippetGenerator.

gchatelet added inline comments.Sep 12 2018, 11:21 PM
tools/llvm-exegesis/lib/SnippetGenerator.h
41

I see. Never mind then.

This revision was automatically updated to reflect the committed changes.