Page MenuHomePhabricator

[ELF] Don't emit .relr.dyn section if there are no relocs
ClosedPublic

Authored by phosek on Sep 8 2018, 3:25 PM.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

phosek created this revision.Sep 8 2018, 3:25 PM
mcgrathr accepted this revision.Sep 8 2018, 4:02 PM
This revision is now accepted and ready to land.Sep 8 2018, 4:02 PM
grimar accepted this revision.EditedSep 10 2018, 12:44 AM
grimar added a subscriber: grimar.

This is LGTM anyways but I have a question/suggestion though.

lld/test/ELF/empty-pack-dyn-relocs.s
1 ↗(On Diff #164579)

Can it be x86? I think relr can perhaps be a generic feature and for those, we use x86 target by default.

ruiu accepted this revision.Sep 10 2018, 8:06 AM

LGTM but please change the "REQUIRES:" line as George suggested.

phosek updated this revision to Diff 164751.Sep 10 2018, 2:30 PM
phosek marked an inline comment as done.
This revision was automatically updated to reflect the committed changes.