This is an archive of the discontinued LLVM Phabricator instance.

[libfuzzer] Enable trace-malloc-unballanced.test on Windows.
ClosedPublic

Authored by metzman on Sep 6 2018, 4:54 PM.

Details

Summary

Enables trace-malloc-unbalanced.test on Windows, fixing two problems it had with Windows before.
The first fix is specifying python instead of relying on a script's shebang since they can't be used on Windows.
The second fix is making the regex tolerate windows' implementation of the "%p" format string.

Diff Detail

Repository
rL LLVM

Event Timeline

metzman created this revision.Sep 6 2018, 4:54 PM
metzman updated this revision to Diff 164323.Sep 6 2018, 4:55 PM
  • Make comment more descriptive

Max could you please take a look when you get a chance (no rush).

This diff enables trace-malloc-unbalanced.test on Windows, fixing two problems it had with Windows before.
The first fix is specifying python instead of relying on a script's shebang since they can't be used on Windows.
The second fix is making the regex tolerate windows' implementation of the "%p" format string.
I don't think there is a nice way to emulate Linux's behavior, but if I see this problem is widespread, I'll revisit.

Dor1s accepted this revision.Sep 6 2018, 8:10 PM

LGTM! I like your comment https://reviews.llvm.org/D51760#1226757, maybe you could paste it into the CL description too?

This revision is now accepted and ready to land.Sep 6 2018, 8:10 PM
metzman edited the summary of this revision. (Show Details)Sep 6 2018, 9:26 PM
metzman added a subscriber: morehouse.
This revision was automatically updated to reflect the committed changes.