Enables trace-malloc-unbalanced.test on Windows, fixing two problems it had with Windows before.
The first fix is specifying python instead of relying on a script's shebang since they can't be used on Windows.
The second fix is making the regex tolerate windows' implementation of the "%p" format string.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Max could you please take a look when you get a chance (no rush).
This diff enables trace-malloc-unbalanced.test on Windows, fixing two problems it had with Windows before.
The first fix is specifying python instead of relying on a script's shebang since they can't be used on Windows.
The second fix is making the regex tolerate windows' implementation of the "%p" format string.
I don't think there is a nice way to emulate Linux's behavior, but if I see this problem is widespread, I'll revisit.
Comment Actions
LGTM! I like your comment https://reviews.llvm.org/D51760#1226757, maybe you could paste it into the CL description too?