[libfuzzer] Fix fuzzer-oom.test on windows and reenable it.

[metzman]

Summary

Patch by Jonathan Metzman (@metzman).

[metzman]

Please take a look.
Another issue with the file extension.
These issues aren't trivial to figure out, I wonder if all tests should compile binaries with exe extensions so problems aren't accidentally introduced.

[Dor1s]

I wonder if there is any trick in lit to resolve this .exe issue. How do other tests work on windows? I see that /compiler-rt/test/asan/TestCases/Windows/ has a bunch of tests that don't use .exe, but some of them have .exe too.

compiler-rt/test/fuzzer/fuzzer-oom.test

4 ↗

(On Diff #164226)

what is "exp"?

[metzman]

In D51735#1226001, @Dor1s wrote:

I wonder if there is any trick in lit to resolve this .exe issue.

Not sure. Maybe cpp_compiler can be some kind of script that wraps clang? Probably the easiest solution for me would be for test binaries to be built with cmake (as they used to be) rather than by lit.

How do other tests work on windows? I see that /compiler-rt/test/asan/TestCases/Windows/ has a bunch of tests that don't use .exe, but some of them have .exe too.

For most windows tests it doesn't matter if exe is used or not. This is the second one where I've seen it make a difference.

compiler-rt/test/fuzzer/fuzzer-oom.test

4 ↗

(On Diff #164226)

https://msdn.microsoft.com/en-us/library/se8y7dcs.aspx
I'm not 100% if it is exp, lib or both being overwritten that causes symbolization to be subtly wrong. But it is true that both get overwritten.
But it is true that if neither is overwritten then things work. My first fix here was actually to reverse the binary names (eg: OutOfMemoryTest-%t )

[Dor1s]

getting ready to land.

test/fuzzer/fuzzer-oom.test

-# FIXME: Disabled on Windows until symbolization works properly.
-UNSUPPORTED: aarch64, windows
-RUN: %cpp_compiler %S/OutOfMemoryTest.cpp -o %t-OutOfMemoryTest
-RUN: %cpp_compiler %S/OutOfMemorySingleLargeMallocTest.cpp -o %t-OutOfMemorySingleLargeMallocTest
-RUN: %cpp_compiler %S/AccumulateAllocationsTest.cpp -o %t-AccumulateAllocationsTest
+UNSUPPORTED: aarch64
+# Tests break on windows unless exe extension is used (because there are periods
+# in expansion of %t, the string after the period is interpreted as the file
+# extension, so each compilation will clobber the previous one's lib and exp
+# files causing symbolization to break).
+RUN: %cpp_compiler %S/OutOfMemoryTest.cpp -o %t-OutOfMemoryTest.exe
+RUN: %cpp_compiler %S/OutOfMemorySingleLargeMallocTest.cpp -o %t-OutOfMemorySingleLargeMallocTest.exe
+RUN: %cpp_compiler %S/AccumulateAllocationsTest.cpp -o %t-AccumulateAllocationsTest.exe
 
-RUN: not %run %t-OutOfMemoryTest -rss_limit_mb=300 2>&1 | FileCheck %s
+RUN: not %run %t-OutOfMemoryTest.exe -rss_limit_mb=300 2>&1 | FileCheck %s
 
 CHECK: ERROR: libFuzzer: out-of-memory (used: {{.*}}; limit: 300Mb)
 CHECK: Test unit written to ./oom-
 SUMMARY: libFuzzer: out-of-memory
 
-RUN: not %run %t-OutOfMemorySingleLargeMallocTest -rss_limit_mb=300    2>&1 | FileCheck %s --check-prefix=SINGLE_LARGE_MALLOC
-RUN: not %run %t-OutOfMemorySingleLargeMallocTest -malloc_limit_mb=300 2>&1 | FileCheck %s --check-prefix=SINGLE_LARGE_MALLOC
-RUN: not %run %t-OutOfMemorySingleLargeMallocTest -rss_limit_mb=1000 -malloc_limit_mb=300 2>&1 | FileCheck %s --check-prefix=SINGLE_LARGE_MALLOC
+RUN: not %run %t-OutOfMemorySingleLargeMallocTest.exe -rss_limit_mb=300    2>&1 | FileCheck %s --check-prefix=SINGLE_LARGE_MALLOC
+RUN: not %run %t-OutOfMemorySingleLargeMallocTest.exe -malloc_limit_mb=300 2>&1 | FileCheck %s --check-prefix=SINGLE_LARGE_MALLOC
+RUN: not %run %t-OutOfMemorySingleLargeMallocTest.exe -rss_limit_mb=1000 -malloc_limit_mb=300 2>&1 | FileCheck %s --check-prefix=SINGLE_LARGE_MALLOC
 
 We used to check for "out-of-memory (malloc(53{{.*}}))", but that would fail
 sometimes, so now we accept any OOM message.
 
 SINGLE_LARGE_MALLOC: libFuzzer: out-of-memory
 SINGLE_LARGE_MALLOC: in LLVMFuzzerTestOneInput
 
 # Check that -rss_limit_mb=0 means no limit.
-RUN: %run %t-AccumulateAllocationsTest -runs=1000 -rss_limit_mb=0
+RUN: %run %t-AccumulateAllocationsTest.exe -runs=1000 -rss_limit_mb=0