This is an archive of the discontinued LLVM Phabricator instance.

[llvm-dwp] Use buffer_stream if output file is not seekable (e.g. "-")
ClosedPublic

Authored by MaskRay on Sep 5 2018, 3:51 PM.

Diff Detail

Event Timeline

MaskRay created this revision.Sep 5 2018, 3:51 PM
MaskRay updated this revision to Diff 164121.Sep 5 2018, 3:55 PM

Remove comment

dblaikie accepted this revision.Sep 5 2018, 4:56 PM
dblaikie added inline comments.
tools/llvm-dwp/llvm-dwp.cpp
707

Could use Optional<buffer_ostream> here to save an extra allocation?

This revision is now accepted and ready to land.Sep 5 2018, 4:56 PM
MaskRay updated this revision to Diff 164130.Sep 5 2018, 5:04 PM

std::unique_ptr -> Optional to save an extra allocation

MaskRay marked an inline comment as done.Sep 5 2018, 5:07 PM
This revision was automatically updated to reflect the committed changes.

Hi,

This commit has caused massive buildbot failures on compilation, see for example http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/builds/5953/steps/build%20stage%201/logs/stdio

I have reverted it as https://reviews.llvm.org/rL341515 to make buildbot green again.

  • Max

Hi,

This commit has caused massive buildbot failures on compilation, see for example http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/builds/5953/steps/build%20stage%201/logs/stdio

I have reverted it as https://reviews.llvm.org/rL341515 to make buildbot green again.

  • Max

Thanks! It was because of existing using namespace cl; in the file. I have changed it to use explicit cl:: qualified names and re-landed the commit