Page MenuHomePhabricator

[CMake] Don't use -rtlib=compiler-rt with -nodefaultlibs.
ClosedPublic

Authored by cdavis5x on Sep 4 2018, 10:45 AM.

Details

Summary

This switch only has an effect at link time. It changes the default
compiler support library to compiler-rt. With -nodefaultlibs, this
library won't get linked anyway; Clang actually warns about that.

Diff Detail

Repository
rUNW libunwind

Event Timeline

cdavis5x created this revision.Sep 4 2018, 10:45 AM
mstorsjo added a subscriber: beanz.Sep 4 2018, 12:22 PM

Sounds sensible to me, although it might be good with a second opinion I think. @beanz?

beanz accepted this revision.Sep 4 2018, 1:58 PM

LGTM.

This revision is now accepted and ready to land.Sep 4 2018, 1:58 PM
This revision was automatically updated to reflect the committed changes.