[LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints

[aykevl]

Summary

This patch adds bindings to C and Go for addCoroutinePassesToExtensionPoints, which is used to add coroutine passes to the correct locations in PassManagerBuilder.

[whitequark]

LGTM

[aykevl]

Can someone merge this patch? I don't have commit access.

[whitequark]

This broke the bots; the LLVM-C API you added should really be in Transforms/Coroutines, not Transforms/IPO. Please update the patch.

[aykevl]

Ok, will update the patch.

[aykevl]

Moved LLVMPassManagerBuilderAddCoroutinePassesToExtensionPoints to lib/Transforms/Coroutines/Coroutines.cpp.
This also required moving of wrap/unwrap functions for the PassManagerBuilder, as they were defined in lib/Transforms/IPO/PassManagerBuilder.cpp instead of in a header file. I think that's the reason I added them originally to PassManagerBuilder.cpp instead of to Coroutines.cpp.

[aykevl]

@whitequark can you take another look at this patch? (I can rebase it if needed).

[whitequark]

Looks good now.

[aykevl]

Rebased on master.

[aykevl]

Merged: https://github.com/llvm/llvm-project/commit/2a7a989c3edc33ad3042052ed50fee37ab254c7d (but Phabricator won't show a second merge)

bindings/go/llvm/transforms_pmbuilder.go

 
 func (pmb PassManagerBuilder) SetDisableSimplifyLibCalls(val bool) {
   C.LLVMPassManagerBuilderSetDisableSimplifyLibCalls(pmb.C, boolToLLVMBool(val))
 }
 
 func (pmb PassManagerBuilder) UseInlinerWithThreshold(threshold uint) {
   C.LLVMPassManagerBuilderUseInlinerWithThreshold(pmb.C, C.uint(threshold))
 }
+
+func (pmb PassManagerBuilder) AddCoroutinePassesToExtensionPoints() {
+  C.LLVMPassManagerBuilderAddCoroutinePassesToExtensionPoints(pmb.C);
+}

include/llvm-c/Transforms/PassManagerBuilder.h

LLVMPassManagerBuilderPopulateModulePassManager(LLVMPassManagerBuilderRef PMB,
                                                 LLVMPassManagerRef PM);
 
 /** See llvm::PassManagerBuilder::populateLTOPassManager. */
 void LLVMPassManagerBuilderPopulateLTOPassManager(LLVMPassManagerBuilderRef PMB,
                                                   LLVMPassManagerRef PM,
                                                   LLVMBool Internalize,
                                                   LLVMBool RunInliner);
 
+/** See llvm::addCoroutinePassesToExtensionPoints. */
+void LLVMPassManagerBuilderAddCoroutinePassesToExtensionPoints(LLVMPassManagerBuilderRef PMB);
+
 /**
  * @}
  */
 
 #ifdef __cplusplus
 }
 #endif
 
 #endif

lib/Transforms/IPO/PassManagerBuilder.cpp

 #include "llvm/Analysis/TargetLibraryInfo.h"
 #include "llvm/Analysis/TypeBasedAliasAnalysis.h"
 #include "llvm/IR/DataLayout.h"
 #include "llvm/IR/LegacyPassManager.h"
 #include "llvm/IR/Verifier.h"
 #include "llvm/Support/CommandLine.h"
 #include "llvm/Support/ManagedStatic.h"
 #include "llvm/Transforms/AggressiveInstCombine/AggressiveInstCombine.h"
+#include "llvm/Transforms/Coroutines.h"
 #include "llvm/Transforms/IPO.h"
 #include "llvm/Transforms/IPO/ForceFunctionAttrs.h"
 #include "llvm/Transforms/IPO/FunctionAttrs.h"
 #include "llvm/Transforms/IPO/InferFunctionAttrs.h"
 #include "llvm/Transforms/InstCombine/InstCombine.h"
 #include "llvm/Transforms/Instrumentation.h"
 #include "llvm/Transforms/Scalar.h"
 #include "llvm/Transforms/Scalar/GVN.h"
void LLVMPassManagerBuilderPopulateLTOPassManager(LLVMPassManagerBuilderRef PMB,
 
   // A small backwards compatibility hack. populateLTOPassManager used to take
   // an RunInliner option.
   if (RunInliner && !Builder->Inliner)
     Builder->Inliner = createFunctionInliningPass();
 
   Builder->populateLTOPassManager(*LPM);
 }
+
+void
+LLVMPassManagerBuilderAddCoroutinePassesToExtensionPoints(LLVMPassManagerBuilderRef PMB) {
+  PassManagerBuilder *Builder = unwrap(PMB);
+  addCoroutinePassesToExtensionPoints(*Builder);
+}