Page MenuHomePhabricator

[LLVM-C] Add bindings for addCoroutinePassesToExtensionPoints
ClosedPublic

Authored by aykevl on Sep 4 2018, 9:48 AM.

Details

Summary

This patch adds bindings to C and Go for addCoroutinePassesToExtensionPoints, which is used to add coroutine passes to the correct locations in PassManagerBuilder.

Diff Detail

Event Timeline

aykevl created this revision.Sep 4 2018, 9:48 AM
This revision is now accepted and ready to land.Sep 15 2018, 12:00 AM

Can someone merge this patch? I don't have commit access.

This revision was automatically updated to reflect the committed changes.

This broke the bots; the LLVM-C API you added should really be in Transforms/Coroutines, not Transforms/IPO. Please update the patch.

Ok, will update the patch.

aykevl updated this revision to Diff 167560.EditedSep 28 2018, 3:22 PM

Moved LLVMPassManagerBuilderAddCoroutinePassesToExtensionPoints to lib/Transforms/Coroutines/Coroutines.cpp.
This also required moving of wrap/unwrap functions for the PassManagerBuilder, as they were defined in lib/Transforms/IPO/PassManagerBuilder.cpp instead of in a header file. I think that's the reason I added them originally to PassManagerBuilder.cpp instead of to Coroutines.cpp.

@whitequark can you take another look at this patch? (I can rebase it if needed).

Looks good now.

aykevl updated this revision to Diff 246266.Feb 24 2020, 11:15 AM

Rebased on master.

Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2020, 11:15 AM
Herald added a subscriber: hiraditya. · View Herald Transcript