This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] Enable tests on Windows
ClosedPublic

Authored by metzman on Aug 31 2018, 10:40 AM.

Details

Summary

Enable tests on Windows and make check-fuzzer pass on it. Make
check-fuzzer pass on Windows by fixing libFuzzer, fixing tests, and by
disabling tests on Windows. Most of these are disabled temporarily as
support for the tests and the features they test will be added
incrementally. Other tests will not be enabled since they require
things that are not on Windows (eg: afl_driver tests). Every test
that was explicitly disabled on Windows has a comment explaining why
(unless obvious like merge-posix.test).

The lit.cfg file was modified to support running tests on windows.
fuzzer-dirs.test was fixed by making the Windows implementation print
the same error message as the posix version.
merge-control-file.test was fixed by making the test binary end with
the ".exe" extension (on all platforms).

Diff Detail

Event Timeline

metzman created this revision.Aug 31 2018, 10:40 AM
metzman updated this revision to Diff 163562.Aug 31 2018, 10:42 AM

update comments

metzman edited the summary of this revision. (Show Details)Aug 31 2018, 12:50 PM
metzman updated this revision to Diff 163579.Aug 31 2018, 12:52 PM
metzman edited the summary of this revision. (Show Details)
  • update comments
  • fix typo

Please take a look Matt.
This enables libfuzzer tests on windows, gets most of them to work, and disables about 20 tests as well (some temporarily, some permanently).

I plan on getting most of the explicitly disabled ones working incrementally.
For example, the fuzzers disabled because they use LLVMFuzzer{Initialize|CustomMutator|CustomCrossOver} all fail because of the same root cause, so I plan on creating a patch to fix this root cause (and not the cause of other problems), soon.

Thank you.

metzman edited the summary of this revision. (Show Details)Aug 31 2018, 12:56 PM
metzman updated this revision to Diff 163597.Aug 31 2018, 2:40 PM
  • fix comment
metzman updated this revision to Diff 163752.Sep 3 2018, 4:37 PM
  • nfc: fix comments.
  • Disable print_unstable_stats
metzman edited the summary of this revision. (Show Details)Sep 3 2018, 4:38 PM
morehouse accepted this revision.Sep 4 2018, 9:36 AM
This revision is now accepted and ready to land.Sep 4 2018, 9:36 AM
This revision was automatically updated to reflect the committed changes.
Herald added subscribers: Restricted Project, llvm-commits. · View Herald TranscriptSep 4 2018, 10:11 AM