This is an archive of the discontinued LLVM Phabricator instance.

lld: Add missing REQUIRES to tests
AbandonedPublic

Authored by tstellar on Aug 31 2018, 10:29 AM.

Details

Event Timeline

tstellar created this revision.Aug 31 2018, 10:29 AM
grimar added a subscriber: grimar.Sep 2 2018, 10:31 PM

None of the rest ELF tests we have using "REQUIRES: x86_64". We already have "REQUIRES: x86" everywhere though. And ELF tests you fix in this patch have it too. So why do you want to add x86_64?

ruiu added a comment.Sep 3 2018, 1:48 AM

Yeah, that was my question too. Can you enable only x86_64 without x86?

tstellar abandoned this revision.Sep 4 2018, 7:04 AM

My mistake. I had been working on the release_70 branch and did not realize the REQUIRES had been added to trunk when I rebased. Looks like this was fixed in r339253. I'll ask Hans to backport that to the stable branch.