This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Use buffered llvm::errs() in the clangd binary.
ClosedPublic

Authored by ioeric on Aug 28 2018, 4:56 AM.

Reviewers

Commits

Summary

Unbuffered stream can cause significant (non-deterministic) latency for the logger.

Trace:

Repository

rCTE Clang Tools Extra

Build Status

Buildable 21995
Build 21995: arc lint + arc unit

sammccall added inline comments.

clangd/tool/ClangdMain.cpp
263	(we still flush each log message).

This revision is now accepted and ready to land.Aug 28 2018, 6:11 AM

This revision was automatically updated to reflect the committed changes.

ioeric marked an inline comment as done.

Path

Size

clangd/

tool/

3 lines

Show First 20 Lines • Show All 253 Lines • ▼ Show 20 Lines	if (EC) {
Tracer = trace::createJSONTracer(*TraceStream, PrettyPrint);		Tracer = trace::createJSONTracer(*TraceStream, PrettyPrint);
}		}
}		}

llvm::Optional<trace::Session> TracingSession;		llvm::Optional<trace::Session> TracingSession;
if (Tracer)		if (Tracer)
TracingSession.emplace(*Tracer);		TracingSession.emplace(*Tracer);

		// Use buffered stream to stderr. Unbuffered stream can cause significant
		// (non-deterministic) latency for the logger.
		sammccallUnsubmitted Done Reply Inline Actions (we still flush each log message). sammccall: (we still flush each log message).
		llvm::errs().SetBuffered();
JSONOutput Out(llvm::outs(), llvm::errs(), LogLevel,		JSONOutput Out(llvm::outs(), llvm::errs(), LogLevel,
InputMirrorStream ? InputMirrorStream.getPointer() : nullptr,		InputMirrorStream ? InputMirrorStream.getPointer() : nullptr,
PrettyPrint);		PrettyPrint);

clangd::LoggingSession LoggingSession(Out);		clangd::LoggingSession LoggingSession(Out);

// If --compile-commands-dir arg was invoked, check value and override default		// If --compile-commands-dir arg was invoked, check value and override default
// path.		// path.
▲ Show 20 Lines • Show All 53 Lines • Show Last 20 Lines