This is an archive of the discontinued LLVM Phabricator instance.

Differential D51013

[WebAssembly] Revert type of wake count in atomic.wake to i32
ClosedPublic

Authored by aheejin on Aug 20 2018, 4:28 PM.

Details

Reviewers
dschuff
Commits
rGf0fe359bc330: [WebAssembly] Revert type of wake count in atomic.wake to i32
rL340235: [WebAssembly] Revert type of wake count in atomic.wake to i32
rC340235: [WebAssembly] Revert type of wake count in atomic.wake to i32
Summary

We decided to revert this from i64 to i32 in Nov 28 CG meeting. Fixes
PR38632.

Diff Detail

Repository
rC Clang

Event Timeline

aheejin created this revision.Aug 20 2018, 4:28 PM
Herald added subscribers: cfe-commits, jfb, sunfish and 2 others. · View Herald TranscriptAug 20 2018, 4:28 PM
Harbormaster completed remote builds in B21704: Diff 161615.Aug 20 2018, 4:28 PM
aheejin edited the summary of this revision. (Show Details)Aug 20 2018, 4:28 PM
aheejin added a parent revision: D51010: [WebAssembly] Revert type of wake count in atomic.wake to i32.
dschuff accepted this revision.Aug 20 2018, 4:34 PM
This revision is now accepted and ready to land.Aug 20 2018, 4:34 PM
Closed by commit rC340235: [WebAssembly] Revert type of wake count in atomic.wake to i32 (authored by aheejin). · Explain WhyAug 20 2018, 4:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
clang/
Basic/
2 lines
test/
CodeGen/
6 lines

Diff 161620

include/clang/Basic/BuiltinsWebAssembly.def

Show All 31 Lines
// Exception handling builtins. // Exception handling builtins.
BUILTIN(__builtin_wasm_throw, "vUiv*", "r") BUILTIN(__builtin_wasm_throw, "vUiv*", "r")
BUILTIN(__builtin_wasm_rethrow, "v", "r") BUILTIN(__builtin_wasm_rethrow, "v", "r")
// Atomic wait and notify. // Atomic wait and notify.
BUILTIN(__builtin_wasm_atomic_wait_i32, "ii*iLLi", "n") BUILTIN(__builtin_wasm_atomic_wait_i32, "ii*iLLi", "n")
BUILTIN(__builtin_wasm_atomic_wait_i64, "iLLi*LLiLLi", "n") BUILTIN(__builtin_wasm_atomic_wait_i64, "iLLi*LLiLLi", "n")
BUILTIN(__builtin_wasm_atomic_notify, "ULLii*LLi", "n") BUILTIN(__builtin_wasm_atomic_notify, "Uii*i", "n")
#undef BUILTIN #undef BUILTIN

test/CodeGen/builtins-wasm.c

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Lines
} }
int f9(long long *addr, long long expected, long long timeout) { int f9(long long *addr, long long expected, long long timeout) {
return __builtin_wasm_atomic_wait_i64(addr, expected, timeout); return __builtin_wasm_atomic_wait_i64(addr, expected, timeout);
// WEBASSEMBLY32: call i32 @llvm.wasm.atomic.wait.i64(i64* %{{.*}}, i64 %{{.*}}, i64 %{{.*}}) // WEBASSEMBLY32: call i32 @llvm.wasm.atomic.wait.i64(i64* %{{.*}}, i64 %{{.*}}, i64 %{{.*}})
// WEBASSEMBLY64: call i32 @llvm.wasm.atomic.wait.i64(i64* %{{.*}}, i64 %{{.*}}, i64 %{{.*}}) // WEBASSEMBLY64: call i32 @llvm.wasm.atomic.wait.i64(i64* %{{.*}}, i64 %{{.*}}, i64 %{{.*}})
} }
unsigned long long f10(int *addr, long long count) { unsigned int f10(int *addr, int count) {
return __builtin_wasm_atomic_notify(addr, count); return __builtin_wasm_atomic_notify(addr, count);
// WEBASSEMBLY32: call i64 @llvm.wasm.atomic.notify(i32* %{{.*}}, i64 %{{.*}}) // WEBASSEMBLY32: call i32 @llvm.wasm.atomic.notify(i32* %{{.*}}, i32 %{{.*}})
// WEBASSEMBLY64: call i64 @llvm.wasm.atomic.notify(i32* %{{.*}}, i64 %{{.*}}) // WEBASSEMBLY64: call i32 @llvm.wasm.atomic.notify(i32* %{{.*}}, i32 %{{.*}})
} }