This is an archive of the discontinued LLVM Phabricator instance.

[llvm-strip] Allow only one input
ClosedPublic

Authored by MaskRay on Aug 20 2018, 3:21 PM.

Details

Summary

Before, llvm-strip accepted a second argument but it would just be ignored.

Diff Detail

Event Timeline

MaskRay created this revision.Aug 20 2018, 3:21 PM
This revision is now accepted and ready to land.Aug 20 2018, 4:00 PM
This revision was automatically updated to reflect the committed changes.

Shouldn't this have a test?

James, as for me, I think (though, don't insist) we might add a test for
this but in this particular case it's not critical / long-term beneficial.
This is a temporary solution anyway. The thing is that llvm-strip doesn't
support multiple inputs while binutils strip does.
So as soon as we fix it (add proper support for multiple input files), the
test will be gone / replaced with a meaningful test for multiple files.

Kind regards,
Alexander Shaposhnikov