This is an archive of the discontinued LLVM Phabricator instance.

Differential D50919

[WebAssembly] Add hasSideEffects flag to catch instructions
ClosedPublic

Authored by aheejin on Aug 17 2018, 1:26 PM.

Details

Reviewers
dschuff
Commits
rGff363539c637: [WebAssembly] Add hasSideEffects flag to catch instructions
rL340433: [WebAssembly] Add hasSideEffects flag to catch instructions
Summary

catch instruction certainly has rather huge side effects and the flag
was missing. At the moment this does not change any unit tests we
currently have.

Diff Detail

Event Timeline

aheejin created this revision.Aug 17 2018, 1:26 PM
Herald added subscribers: llvm-commits, sunfish, jgravelle-google, sbc100. · View Herald TranscriptAug 17 2018, 1:27 PM
Harbormaster completed remote builds in B21630: Diff 161311.Aug 17 2018, 1:27 PM
aheejin updated this revision to Diff 161312.Aug 17 2018, 1:28 PM

spaces

Harbormaster completed remote builds in B21631: Diff 161312.Aug 17 2018, 1:28 PM
aheejin mentioned this in D50980: [WebAssembly] Restore __stack_pointer after catch instructions.Aug 21 2018, 1:22 PM
aheejin added a comment.Aug 22 2018, 10:59 AM

Ping

dschuff accepted this revision.Aug 22 2018, 11:10 AM
This revision is now accepted and ready to land.Aug 22 2018, 11:10 AM
Closed by commit rL340433: [WebAssembly] Add hasSideEffects flag to catch instructions (authored by aheejin). · Explain WhyAug 22 2018, 11:23 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Target/
WebAssembly/
2 lines

Diff 161312

lib/Target/WebAssembly/WebAssemblyInstrControl.td

Show First 20 Lines • Show All 166 Lines • ▼ Show 20 Lines
// Region within which an exception is caught: try / end_try // Region within which an exception is caught: try / end_try
let Uses = [VALUE_STACK], Defs = [VALUE_STACK] in { let Uses = [VALUE_STACK], Defs = [VALUE_STACK] in {
defm TRY : NRI<(outs), (ins Signature:$sig), [], "try \t$sig", 0x06>; defm TRY : NRI<(outs), (ins Signature:$sig), [], "try \t$sig", 0x06>;
defm END_TRY : NRI<(outs), (ins), [], "end_try", 0x0b>; defm END_TRY : NRI<(outs), (ins), [], "end_try", 0x0b>;
} // Uses = [VALUE_STACK], Defs = [VALUE_STACK] } // Uses = [VALUE_STACK], Defs = [VALUE_STACK]
// Catching an exception: catch / catch_all // Catching an exception: catch / catch_all
let hasCtrlDep = 1 in { let hasCtrlDep = 1, hasSideEffects = 1 in {
defm CATCH_I32 : I<(outs I32:$dst), (ins i32imm:$tag), defm CATCH_I32 : I<(outs I32:$dst), (ins i32imm:$tag),
(outs), (ins i32imm:$tag), (outs), (ins i32imm:$tag),
[(set I32:$dst, (int_wasm_catch imm:$tag))], [(set I32:$dst, (int_wasm_catch imm:$tag))],
"i32.catch \t$dst, $tag", "i32.catch \t$tag", 0x07>; "i32.catch \t$dst, $tag", "i32.catch \t$tag", 0x07>;
defm CATCH_I64 : I<(outs I64:$dst), (ins i32imm:$tag), defm CATCH_I64 : I<(outs I64:$dst), (ins i32imm:$tag),
(outs), (ins i32imm:$tag), (outs), (ins i32imm:$tag),
[(set I64:$dst, (int_wasm_catch imm:$tag))], [(set I64:$dst, (int_wasm_catch imm:$tag))],
"i64.catch \t$dst, $tag", "i64.catch \t$tag", 0x07>; "i64.catch \t$dst, $tag", "i64.catch \t$tag", 0x07>;
Show All 15 Lines