This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] [NFC] Split up summary generation in RetainCountChecker in two methods
ClosedPublic

Authored by george.karpenkov on Aug 15 2018, 6:31 PM.

Diff Detail

Repository
rC Clang

Event Timeline

NoQ accepted this revision.Aug 15 2018, 6:38 PM

Ah, finally someone tried to figure out if S is ever overwritten here.

... clang-tidy check for do ... while(0) anyone? :P

People often write do ... while(0); when they are ashamed to write goto fail;. I suspect that it'd be pretty hard for path-insensitive analysis to figure out that we could actually replace breaks with returns here.

clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountSummaries.h
502 ↗(On Diff #160963)

I like it how this dude became private as well.

This revision is now accepted and ready to land.Aug 15 2018, 6:38 PM
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.