... clang-tidy check for do ... while(0) anyone? :P
Details
Details
Diff Detail
Diff Detail
- Repository
- rC Clang
Event Timeline
Comment Actions
Ah, finally someone tried to figure out if S is ever overwritten here.
... clang-tidy check for do ... while(0) anyone? :P
People often write do ... while(0); when they are ashamed to write goto fail;. I suspect that it'd be pretty hard for path-insensitive analysis to figure out that we could actually replace breaks with returns here.
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountSummaries.h | ||
---|---|---|
502 ↗ | (On Diff #160963) | I like it how this dude became private as well. |