Page MenuHomePhabricator

[WebAssembly] Don't compress LEBs by default
ClosedPublic

Authored by sbc100 on Aug 14 2018, 12:11 PM.

Details

Summary

LEB compression breaks debug info so we don't want to enable
it by default, even at high optimization levels.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Aug 14 2018, 12:11 PM

Perhaps I should make this -z compress although I'm not sure what the policy is in using -z keywords vs regular flags.

sbc100 updated this revision to Diff 160665.Aug 14 2018, 12:15 PM
  • add check for -r
This revision is now accepted and ready to land.Aug 14 2018, 5:26 PM
This revision was automatically updated to reflect the committed changes.
ruiu added inline comments.Aug 19 2018, 9:55 PM
lld/trunk/wasm/Driver.cpp
398

All Config members that correspond to command line options have the same name as the command line options, so this should be Config->CompressRelocations.