This is an archive of the discontinued LLVM Phabricator instance.

[libunwind] [cmake] Add MINGW_LIBRARIES to the linker flags
ClosedPublic

Authored by mstorsjo on Aug 13 2018, 1:46 PM.

Details

Summary

This is essential when building with -nodefaultlibs.

In some CMake versions (noticed in 3.5.1), the same libraries are picked up from CMAKE_REQUIRED_LIBRARIES in some exceptional situations (if CXX probing failed, due to libc++ not being built yet, the libraries from CMAKE_REQUIRED_LIBRARIES are used for linking the target library), but not at all in other newer CMake versions (3.10).

This is similar to what already is done in libcxxabi in SVN r302760 and libcxx in SVN r312498.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Aug 13 2018, 1:46 PM
phosek accepted this revision.Aug 13 2018, 8:43 PM

LGTM

This revision is now accepted and ready to land.Aug 13 2018, 8:43 PM
This revision was automatically updated to reflect the committed changes.