Add a newline to SourceLocation dump output

[steveire]

Summary

Migrate callers to print().

dump() should be useful to downstreams and third parties as a debugging
aid. Everyone trips up on this and creates confusing output.

cfe/trunk/lib/ARCMigrate/TransGCAttrs.cpp

 
 void MigrationContext::dumpGCAttrs() {
   llvm::errs() << "\n################\n";
   for (unsigned i = 0, e = GCAttrs.size(); i != e; ++i) {
     GCAttrOccurrence &Attr = GCAttrs[i];
     llvm::errs() << "KIND: "
         << (Attr.Kind == GCAttrOccurrence::Strong ? "strong" : "weak");
     llvm::errs() << "\nLOC: ";
-    Attr.Loc.dump(Pass.Ctx.getSourceManager());
+    Attr.Loc.print(llvm::errs(), Pass.Ctx.getSourceManager());
     llvm::errs() << "\nTYPE: ";
     Attr.ModifiedType.dump();
     if (Attr.Dcl) {
       llvm::errs() << "DECL:\n";
       Attr.Dcl->dump();
     } else {
       llvm::errs() << "DECL: NONE";
     }
     llvm::errs() << "\nMIGRATABLE: " << Attr.FullyMigratable;
     llvm::errs() << "\n----------------\n";
   }
   llvm::errs() << "\n################\n";
 }

cfe/trunk/lib/AST/CommentLexer.cpp

 #include "llvm/Support/ConvertUTF.h"
 #include "llvm/Support/ErrorHandling.h"
 
 namespace clang {
 namespace comments {
 
 void Token::dump(const Lexer &L, const SourceManager &SM) const {
   llvm::errs() << "comments::Token Kind=" << Kind << " ";
-  Loc.dump(SM);
+  Loc.print(llvm::errs(), SM);
   llvm::errs() << " " << Length << " \"" << L.getSpelling(*this, SM) << "\"\n";
 }
 
 static inline bool isHTMLNamedCharacterReferenceCharacter(char C) {
   return isLetter(C);
 }
 
 static inline bool isHTMLDecimalCharacterReferenceCharacter(char C) {

cfe/trunk/lib/Analysis/LiveVariables.cpp

llvm::sort(declVec.begin(), declVec.end(),
                [](const Decl *A, const Decl *B) {
                  return A->getBeginLoc() < B->getBeginLoc();
                });
 
     for (std::vector<const VarDecl*>::iterator di = declVec.begin(),
          de = declVec.end(); di != de; ++di) {
       llvm::errs() << " " << (*di)->getDeclName().getAsString()
                    << " <";
-      (*di)->getLocation().dump(M);
+      (*di)->getLocation().print(llvm::errs(), M);
       llvm::errs() << ">\n";
     }
   }
   llvm::errs() << "\n";
 }
 
 const void *LiveVariables::getTag() { static int x; return &x; }
 const void *RelaxedLiveVariables::getTag() { static int x; return &x; }

cfe/trunk/lib/Basic/Diagnostic.cpp

if (ID.isValid()) {
     F.StateTransitions.push_back({FirstDiagState, 0});
   }
   return &F;
 }
 
 void DiagnosticsEngine::DiagStateMap::dump(SourceManager &SrcMgr,
                                            StringRef DiagName) const {
   llvm::errs() << "diagnostic state at ";
-  CurDiagStateLoc.dump(SrcMgr);
+  CurDiagStateLoc.print(llvm::errs(), SrcMgr);
   llvm::errs() << ": " << CurDiagState << "\n";
 
   for (auto &F : Files) {
     FileID ID = F.first;
     File &File = F.second;
 
     bool PrintedOuterHeading = false;
     auto PrintOuterHeading = [&] {
       if (PrintedOuterHeading) return;
       PrintedOuterHeading = true;
 
       llvm::errs() << "File " << &File << " <FileID " << ID.getHashValue()
                    << ">: " << SrcMgr.getBuffer(ID)->getBufferIdentifier();
       if (F.second.Parent) {
         std::pair<FileID, unsigned> Decomp =
             SrcMgr.getDecomposedIncludedLoc(ID);
         assert(File.ParentOffset == Decomp.second);
         llvm::errs() << " parent " << File.Parent << " <FileID "
                      << Decomp.first.getHashValue() << "> ";
         SrcMgr.getLocForStartOfFile(Decomp.first)
               .getLocWithOffset(Decomp.second)
-              .dump(SrcMgr);
+              .print(llvm::errs(), SrcMgr);
       }
       if (File.HasLocalTransitions)
         llvm::errs() << " has_local_transitions";
       llvm::errs() << "\n";
     };
 
     if (DiagName.empty())
       PrintOuterHeading();
 
     for (DiagStatePoint &Transition : File.StateTransitions) {
       bool PrintedInnerHeading = false;
       auto PrintInnerHeading = [&] {
         if (PrintedInnerHeading) return;
         PrintedInnerHeading = true;
 
         PrintOuterHeading();
         llvm::errs() << "  ";
         SrcMgr.getLocForStartOfFile(ID)
               .getLocWithOffset(Transition.Offset)
-              .dump(SrcMgr);
+              .print(llvm::errs(), SrcMgr);
         llvm::errs() << ": state " << Transition.State << ":\n";
       };
 
       if (DiagName.empty())
         PrintInnerHeading();
 
       for (auto &Mapping : *Transition.State) {
         StringRef Option =

cfe/trunk/lib/Basic/SourceLocation.cpp

SourceLocation::printToString(const SourceManager &SM) const {
   std::string S;
   llvm::raw_string_ostream OS(S);
   print(OS, SM);
   return OS.str();
 }
 
 LLVM_DUMP_METHOD void SourceLocation::dump(const SourceManager &SM) const {
   print(llvm::errs(), SM);
+  llvm::errs() << '\n';
 }
 
 //===----------------------------------------------------------------------===//
 // FullSourceLoc
 //===----------------------------------------------------------------------===//
 
 FileID FullSourceLoc::getFileID() const {
   assert(isValid());

cfe/trunk/lib/Lex/Preprocessor.cpp

void Preprocessor::DumpToken(const Token &Tok, bool DumpFlags) const {
   }
 
   llvm::errs() << "\tLoc=<";
   DumpLocation(Tok.getLocation());
   llvm::errs() << ">";
 }
 
 void Preprocessor::DumpLocation(SourceLocation Loc) const {
-  Loc.dump(SourceMgr);
+  Loc.print(llvm::errs(), SourceMgr);
 }
 
 void Preprocessor::DumpMacro(const MacroInfo &MI) const {
   llvm::errs() << "MACRO: ";
   for (unsigned i = 0, e = MI.getNumTokens(); i != e; ++i) {
     DumpToken(MI.getReplacementToken(i));
     llvm::errs() << "  ";
   }