This is an archive of the discontinued LLVM Phabricator instance.

[Sema] fix -Wfloat-conversion test case.
ClosedPublic

Authored by nickdesaulniers on Aug 13 2018, 10:08 AM.

Reviewers

aaron.ballman
gkistanova

Commits

Summary

Fixes r339581 ("[SEMA] add more -Wfloat-conversion to
compound assigment analysis").

This test case was caught in postsubmit testing.

Repository

rC Clang

Build Status

Buildable 21395
Build 21395: arc lint + arc unit

LGTM, though you don't need review for fixing bots.

This revision is now accepted and ready to land.Aug 13 2018, 10:50 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

test/

Sema/

2 lines

Show First 20 Lines • Show All 353 Lines • ▼ Show 20 Lines	void test_7631400(void) {
char s = LONG_MAX; // expected-warning {{implicit conversion from 'long' to 'char' changes value}}		char s = LONG_MAX; // expected-warning {{implicit conversion from 'long' to 'char' changes value}}
}		}

// <rdar://problem/7676608>: assertion for compound operators with non-integral RHS		// <rdar://problem/7676608>: assertion for compound operators with non-integral RHS
void f7676608(int);		void f7676608(int);
void test_7676608(void) {		void test_7676608(void) {
float q = 0.7f;		float q = 0.7f;
char c = 5;		char c = 5;
f7676608(c *= q);		f7676608(c *= q); // expected-warning {{conversion}}
}		}

// <rdar://problem/7904686>		// <rdar://problem/7904686>
void test_7904686(void) {		void test_7904686(void) {
const int i = -1;		const int i = -1;
unsigned u1 = i; // expected-warning {{implicit conversion changes signedness}}		unsigned u1 = i; // expected-warning {{implicit conversion changes signedness}}
u1 = i; // expected-warning {{implicit conversion changes signedness}}		u1 = i; // expected-warning {{implicit conversion changes signedness}}

▲ Show 20 Lines • Show All 80 Lines • Show Last 20 Lines