This is an archive of the discontinued LLVM Phabricator instance.

Differential D50543

[libcxx] Mark charconv tests as failing for previous libcxx versions.
ClosedPublic

Authored by vsapsai on Aug 9 2018, 5:49 PM.

Details

Reviewers
mclow.lists
ldionne
EricWF
Commits
rG0b8efae6bc1a: [libcxx] Mark charconv tests as failing for previous libcxx versions.
rCXX339451: [libcxx] Mark charconv tests as failing for previous libcxx versions.
rL339451: [libcxx] Mark charconv tests as failing for previous libcxx versions.
Summary

<charconv> was added in r338479. Previous libcxx versions don't have
this functionality and corresponding tests should be failing.

Diff Detail

Repository
rL LLVM

Event Timeline

vsapsai created this revision.Aug 9 2018, 5:49 PM
Herald added a reviewer: EricWF. · View Herald TranscriptAug 9 2018, 5:49 PM
Herald added subscribers: dexonsmith, christof. · View Herald Transcript
lichray added a comment.Aug 9 2018, 6:06 PM

LGTM. @ldionne 's job to confirm.

ldionne accepted this revision.Aug 10 2018, 6:21 AM

Ship it!

This revision is now accepted and ready to land.Aug 10 2018, 6:21 AM
Closed by commit rL339451: [libcxx] Mark charconv tests as failing for previous libcxx versions. (authored by vsapsai). · Explain WhyAug 10 2018, 10:04 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptAug 10 2018, 10:04 AM
vsapsai added a comment.Aug 10 2018, 10:21 AM

Thanks for the review.

Revision Contents

PathSize
libcxx/
trunk/
test/
std/
utilities/
charconv/
charconv.from.chars/
9 lines
charconv.to.chars/
9 lines

Diff 160132

libcxx/trunk/test/std/utilities/charconv/charconv.from.chars/integral.pass.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// The LLVM Compiler Infrastructure // The LLVM Compiler Infrastructure
// //
// This file is dual licensed under the MIT and the University of Illinois Open // This file is dual licensed under the MIT and the University of Illinois Open
// Source Licenses. See LICENSE.TXT for details. // Source Licenses. See LICENSE.TXT for details.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: c++98, c++03, c++11 // UNSUPPORTED: c++98, c++03, c++11
// XFAIL: with_system_cxx_lib=macosx10.13
// XFAIL: with_system_cxx_lib=macosx10.12
// XFAIL: with_system_cxx_lib=macosx10.11
// XFAIL: with_system_cxx_lib=macosx10.10
// XFAIL: with_system_cxx_lib=macosx10.9
// XFAIL: with_system_cxx_lib=macosx10.8
// XFAIL: with_system_cxx_lib=macosx10.7
// <charconv> // <charconv>
// from_chars_result from_chars(const char* first, const char* last, // from_chars_result from_chars(const char* first, const char* last,
// Integral& value, int base = 10) // Integral& value, int base = 10)
#include "charconv_test_helpers.h" #include "charconv_test_helpers.h"
template <typename T> template <typename T>
▲ Show 20 Lines • Show All 164 Lines • Show Last 20 Lines

libcxx/trunk/test/std/utilities/charconv/charconv.to.chars/integral.pass.cpp

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// The LLVM Compiler Infrastructure // The LLVM Compiler Infrastructure
// //
// This file is dual licensed under the MIT and the University of Illinois Open // This file is dual licensed under the MIT and the University of Illinois Open
// Source Licenses. See LICENSE.TXT for details. // Source Licenses. See LICENSE.TXT for details.
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// UNSUPPORTED: c++98, c++03, c++11 // UNSUPPORTED: c++98, c++03, c++11
// XFAIL: with_system_cxx_lib=macosx10.13
// XFAIL: with_system_cxx_lib=macosx10.12
// XFAIL: with_system_cxx_lib=macosx10.11
// XFAIL: with_system_cxx_lib=macosx10.10
// XFAIL: with_system_cxx_lib=macosx10.9
// XFAIL: with_system_cxx_lib=macosx10.8
// XFAIL: with_system_cxx_lib=macosx10.7
// <charconv> // <charconv>
// to_chars_result to_chars(char* first, char* last, Integral value, // to_chars_result to_chars(char* first, char* last, Integral value,
// int base = 10) // int base = 10)
#include "charconv_test_helpers.h" #include "charconv_test_helpers.h"
template <typename T> template <typename T>
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines