This is an archive of the discontinued LLVM Phabricator instance.

[ASTImporter] Improved import of friend templates.
ClosedPublic

Authored by balazske on Aug 9 2018, 9:04 AM.

Details

Summary

When importing a friend class template declaration,
this declaration should not be merged with any other existing declaration
for the same type. Otherwise the getFriendDecl of the FriendDecl can point
to an other already referenced declaration, this case causes problems.
Additionally the previous decl of class templates is set at import.

Diff Detail

Repository
rL LLVM

Event Timeline

balazske created this revision.Aug 9 2018, 9:04 AM
a_sidorin accepted this revision.Aug 11 2018, 1:26 PM
a_sidorin added a subscriber: a_sidorin.
a_sidorin added inline comments.
unittests/AST/ASTImporterTest.cpp
2721 ↗(On Diff #159935)

Should we use EXPECT_EQ for "To" checks?

This revision is now accepted and ready to land.Aug 11 2018, 1:26 PM
balazske updated this revision to Diff 160335.Aug 13 2018, 5:58 AM
  • replaced ASSERT in test
balazske marked an inline comment as done.Aug 13 2018, 5:58 AM
This revision was automatically updated to reflect the committed changes.