Fixes PR37524.
The exception handling encodings for x86_64 in kernel code model has been changed with r309884. Restore it to correct ones. These encodings include PersonalityEncoding, LSDAEncoding and TTypeEncoding.
Differential D50490
Restore correct x86_64 EH encodings in kernel code model lliu0 on Aug 8 2018, 10:15 PM. Authored by
Details Fixes PR37524. The exception handling encodings for x86_64 in kernel code model has been changed with r309884. Restore it to correct ones. These encodings include PersonalityEncoding, LSDAEncoding and TTypeEncoding.
Diff Detail
Event TimelineComment Actions
So all things considered this LGTM. Comment Actions Rafael's commit message was still correct, this shouldn't be part of MCObjectFileInfo, it should be in TargetLoweringObjectFile, which is only used by CodeGen. Give me a minute to try to untangle that. Comment Actions If we move some of this logic back up into CodeGen, that removes the need to pass the full code model to the assembler. I implemented this in D50533. Please take a look. You should be able to rebase your change to the x86_64 EH encodings on that, removing the need to thread the code model to MC. Comment Actions Code looks good, but we should strengthen the test case.
|
This looks like it's the wrong way around compared to the rest. I'm also not sure why the medium code model is treated like small in the PIC case, but like large in the non-PIC case, shouldn't it be the same for both?