This is an archive of the discontinued LLVM Phabricator instance.

[DWARF] Verifier now handles .debug_types sections.
ClosedPublic

Authored by probinson on Aug 8 2018, 10:48 AM.

Details

Summary

This will incidentally make it really easy to handle multiple .debug_info sections for v5.

Diff Detail

Event Timeline

probinson created this revision.Aug 8 2018, 10:48 AM
JDevlieghere accepted this revision.Aug 8 2018, 2:35 PM

Thanks Paul! One nit, otherwise this LGTM.

llvm/include/llvm/DebugInfo/DWARF/DWARFVerifier.h
166

I believe we are moving to returning unsigneds instead of booleans. I'd do the same here, even if the first error is fatal. Maybe you can do the same for verifyUnitContents for consistency?

This revision is now accepted and ready to land.Aug 8 2018, 2:35 PM
probinson marked an inline comment as done.Aug 8 2018, 4:39 PM
probinson added inline comments.
llvm/include/llvm/DebugInfo/DWARF/DWARFVerifier.h
166

Done in the commit, coming soon.

This revision was automatically updated to reflect the committed changes.
probinson marked an inline comment as done.