When compiling with optimizations, mips requires various helper routines(__ashldi3 and the like) contained in libgcc_s.
Conditionally include libgcc_s in the set of libraries to be linked to.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
This hard-coding seems to be counter-productive, it could be compiler-rt just as well.
Comment Actions
@joerg Would it be okay to commit this?
The LIBUNWIND_HAS_GCC_S_LIB although declared, did not have its value used anywhere unlike LIBUNWIND_HAS_C_LIB and LIBUNWIND_HAS_DL_LIB which had been declared/used similarly.
The added line is only executed if the following block is (cmake/config-ix.cmake):
if (NOT LIBUNWIND_USE_COMPILER_RT) check_library_exists(gcc_s __gcc_personality_v0 "" LIBUNWIND_HAS_GCC_S_LIB) endif()
in which case compiler-rt is not being used anyway, if that's what you were referring to.