This is an archive of the discontinued LLVM Phabricator instance.

Differential D50132

[clang-format] Add some text proto functions to Google style
ClosedPublic

Authored by krasimir on Aug 1 2018, 12:51 AM.

Details

Reviewers
djasper
klimek
Commits
rGce0b8d6935fc: [clang-format] Add some text proto functions to Google style
rC338524: [clang-format] Add some text proto functions to Google style
rL338524: [clang-format] Add some text proto functions to Google style
Summary

Adds 2 functions taking a text proto argument.

Diff Detail

Event Timeline

krasimir created this revision.Aug 1 2018, 12:51 AM
Herald added subscribers: cfe-commits, acoomans. · View Herald TranscriptAug 1 2018, 12:51 AM
krasimir added a reviewer: klimek.Aug 1 2018, 5:09 AM
djasper accepted this revision.Aug 1 2018, 5:32 AM

Looks good.

This revision is now accepted and ready to land.Aug 1 2018, 5:32 AM
Closed by commit rL338524: [clang-format] Add some text proto functions to Google style (authored by krasimir). · Explain WhyAug 1 2018, 5:35 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptAug 1 2018, 5:35 AM

Revision Contents

PathSize
lib/
Format/
2 lines

Diff 158473

lib/Format/Format.cpp

Show First 20 Lines • Show All 771 Lines • ▼ Show 20 Lines GoogleStyle.RawStringFormats = {
"PB", "PB",
"proto", "proto",
"PROTO", "PROTO",
}, },
/*EnclosingFunctionNames=*/ /*EnclosingFunctionNames=*/
{ {
"EqualsProto", "EqualsProto",
"EquivToProto", "EquivToProto",
"PARSE_PARTIAL_TEXT_PROTO",
"PARSE_TEST_PROTO", "PARSE_TEST_PROTO",
"PARSE_TEXT_PROTO", "PARSE_TEXT_PROTO",
"ParseTextOrDie", "ParseTextOrDie",
"ParseTextProtoOrDie",
}, },
/*CanonicalDelimiter=*/"", /*CanonicalDelimiter=*/"",
/*BasedOnStyle=*/"google", /*BasedOnStyle=*/"google",
}, },
}; };
GoogleStyle.SpacesBeforeTrailingComments = 2; GoogleStyle.SpacesBeforeTrailingComments = 2;
GoogleStyle.Standard = FormatStyle::LS_Auto; GoogleStyle.Standard = FormatStyle::LS_Auto;
▲ Show 20 Lines • Show All 1,454 Lines • Show Last 20 Lines