Page MenuHomePhabricator

acoomans (Arnaud Coomans)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 2 2018, 3:13 PM (67 w, 20 h)

Recent Activity

Aug 16 2018

acoomans added a comment to D50410: Removing -debug-info-macros from option suggestions test.

@mattd thanks for confirming. I tried clang -cc1as -target x86_64-scei-ps4 -debug-info-macros and got suggestions.

Aug 16 2018, 9:04 AM
acoomans abandoned D50802: Expression autocompletion with variables and symbols.

@teemperor Nice. Looks like you're way ahead of me. I'll abandon this. Let me know if you want help with your code!

Aug 16 2018, 8:57 AM

Aug 15 2018

acoomans created D50802: Expression autocompletion with variables and symbols.
Aug 15 2018, 1:20 PM
acoomans updated subscribers of D50410: Removing -debug-info-macros from option suggestions test.

@mattd @Sunil_Srivastava if you have access to the PS4 SDK, could you tell if the -debug-info-macro command line clang option is available? Thank you

Aug 15 2018, 12:32 PM

Aug 14 2018

acoomans added a comment to D50535: Fix selective formatting of ObjC scope.

@jolesiak let me know what you think

Aug 14 2018, 12:05 PM
acoomans updated subscribers of D50535: Fix selective formatting of ObjC scope.
Aug 14 2018, 12:05 PM

Aug 13 2018

acoomans added a comment to D50410: Removing -debug-info-macros from option suggestions test.

Can anyone confirm the -debug-info-macro command line option is unavailable with the PS4 SDK?

Aug 13 2018, 8:30 AM

Aug 10 2018

acoomans accepted D50467: [SEMA] add more -Wfloat-conversion to compound assigment analysis.

LGTM

Aug 10 2018, 11:46 AM

Aug 9 2018

acoomans added a comment to D50535: Fix selective formatting of ObjC scope.

I probably don't need a unit test AND a lit test, but I'm unsure which one is best here. Any suggestion?

Aug 9 2018, 2:26 PM
acoomans abandoned D49580: [clang-format] Adding style option for absolute formatting.

Changed approach based on feedback. New changeset: https://reviews.llvm.org/D50535

Aug 9 2018, 2:24 PM
acoomans updated the summary of D50535: Fix selective formatting of ObjC scope.
Aug 9 2018, 2:24 PM
acoomans created D50535: Fix selective formatting of ObjC scope.
Aug 9 2018, 2:21 PM
acoomans created D50515: Re-push "[Option] Fix PR37006 prefix choice in findNearest".
Aug 9 2018, 8:36 AM · Restricted Project
acoomans updated the summary of D50410: Removing -debug-info-macros from option suggestions test.
Aug 9 2018, 8:33 AM
acoomans added a comment to D49549: Change 'clang-test' to 'check-clang' on the hacking webpage.

@JDevlieghere Thanks! subscribers -> makes sense, will do

Aug 9 2018, 8:27 AM
acoomans added a comment to D49549: Change 'clang-test' to 'check-clang' on the hacking webpage.

Ping

Aug 9 2018, 8:11 AM

Aug 7 2018

acoomans updated subscribers of D50410: Removing -debug-info-macros from option suggestions test.

@probinson does this sound a plausible explanation? Do you have access to a PS4 SDK to confirm the -debug-info-macro isn't available at all?

Aug 7 2018, 3:09 PM
acoomans created D50410: Removing -debug-info-macros from option suggestions test.
Aug 7 2018, 3:08 PM

Aug 1 2018

acoomans added a comment to D49580: [clang-format] Adding style option for absolute formatting.

Thanks for the review. I’ll update when I’m back from vacation

Aug 1 2018, 11:34 AM
acoomans added a comment to D50147: clang-format: support external styles.

Doesn’t clang-format support project-based .clang-format or _clang-format? How do they play with this diff?

Aug 1 2018, 11:22 AM · Restricted Project, Restricted Project

Jul 23 2018

acoomans added a comment to D49580: [clang-format] Adding style option for absolute formatting.

I don't know; I just picked a random bug from the Bugzilla to get myself familiarized with the LLVM codebase :)

Jul 23 2018, 10:12 AM
acoomans added a comment to D49580: [clang-format] Adding style option for absolute formatting.

Also ping @jolesiak since he initially filed the report

Jul 23 2018, 10:07 AM
acoomans added a comment to D49580: [clang-format] Adding style option for absolute formatting.

@djasper I updated the description of the diff.

Jul 23 2018, 10:05 AM
acoomans updated the summary of D49580: [clang-format] Adding style option for absolute formatting.
Jul 23 2018, 10:03 AM

Jul 20 2018

acoomans updated the diff for D49580: [clang-format] Adding style option for absolute formatting.
Jul 20 2018, 12:49 PM
acoomans added reviewers for D49580: [clang-format] Adding style option for absolute formatting: djasper, klimek, jolesiak.
Jul 20 2018, 9:53 AM

Jul 19 2018

acoomans added a comment to D49580: [clang-format] Adding style option for absolute formatting.

An alternative to changing the whole behavior would be to make it a parameter / configuration option.

Jul 19 2018, 5:29 PM
acoomans updated the summary of D49580: [clang-format] Adding style option for absolute formatting.
Jul 19 2018, 5:28 PM
acoomans created D49580: [clang-format] Adding style option for absolute formatting.
Jul 19 2018, 5:26 PM
acoomans updated the summary of D49549: Change 'clang-test' to 'check-clang' on the hacking webpage.
Jul 19 2018, 9:12 AM
acoomans created D49549: Change 'clang-test' to 'check-clang' on the hacking webpage.
Jul 19 2018, 9:02 AM