This is an archive of the discontinued LLVM Phabricator instance.

[X86] FastISel fall back on !absolute_symbol GVs
ClosedPublic

Authored by vlad.tsyrklevich on Jul 31 2018, 4:36 PM.

Details

Summary

D25878, which added support for !absolute_symbol for normal X86 ISel,
did not add support for materializing references to absolute symbols for
X86 FastISel. This causes build failures because FastISel generates
PC-relative relocations for absolute symbols. Fall back to normal ISel
for references to !absolute_symbol GVs. Fix for PR38200.

Diff Detail

Event Timeline

pcc accepted this revision.Jul 31 2018, 4:43 PM

LGTM

This revision is now accepted and ready to land.Jul 31 2018, 4:43 PM
This revision was automatically updated to reflect the committed changes.