The condition to create a new phdr must also check the usage of "AT>" linker script command, and create a new PT_LOAD header if a new LMARegion is used.
This fixes PR38307
Differential D50052
[LLD] Improve handling of AT> linker script commands kschwarz on Jul 31 2018, 4:24 AM. Authored by
Details
The condition to create a new phdr must also check the usage of "AT>" linker script command, and create a new PT_LOAD header if a new LMARegion is used. This fixes PR38307
Diff Detail Event TimelineComment Actions Seems several independent bugs are fixed here. I would suggest splitting this patch to independent reviews. (Also, an uploaded patch has no context. Please include it next time (https://llvm.org/docs/Phabricator.html#id3).)
Comment Actions On the second look, this change is more independent from D50133 than I thought initially. Comment Actions Could you give me a few days to review code since we are working in different time zones?
|
Can you split this change and the corresponding test case (at8.test) to the different patch?