This is an archive of the discontinued LLVM Phabricator instance.

[analyzer] Store ValueDecl in DeclRegion
ClosedPublic

Authored by george.karpenkov on Jul 30 2018, 11:41 AM.

Reviewers

dcoughlin
NoQ

Commits

Summary

All use cases of DeclRegion actually have ValueDecl there,
and getting the name from declaration comes in very handy.

This revision is now accepted and ready to land.Jul 30 2018, 11:42 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

clang/

include/

clang/

StaticAnalyzer/

Core/

PathSensitive/

6 lines

Show First 20 Lines • Show All 891 Lines • ▼ Show 20 Lines	public:

static bool classof(const MemRegion* R) {		static bool classof(const MemRegion* R) {
return R->getKind() == CompoundLiteralRegionKind;		return R->getKind() == CompoundLiteralRegionKind;
}		}
};		};

class DeclRegion : public TypedValueRegion {		class DeclRegion : public TypedValueRegion {
protected:		protected:
const Decl *D;		const ValueDecl *D;

DeclRegion(const Decl d, const MemRegion sReg, Kind k)		DeclRegion(const ValueDecl d, const MemRegion sReg, Kind k)
: TypedValueRegion(sReg, k), D(d) {		: TypedValueRegion(sReg, k), D(d) {
assert(classof(this));		assert(classof(this));
assert(d);		assert(d);
}		}

static void ProfileRegion(llvm::FoldingSetNodeID& ID, const Decl *D,		static void ProfileRegion(llvm::FoldingSetNodeID& ID, const Decl *D,
const MemRegion* superRegion, Kind k);		const MemRegion* superRegion, Kind k);

public:		public:
const Decl *getDecl() const { return D; }		const ValueDecl *getDecl() const { return D; }
void Profile(llvm::FoldingSetNodeID& ID) const override;		void Profile(llvm::FoldingSetNodeID& ID) const override;

static bool classof(const MemRegion* R) {		static bool classof(const MemRegion* R) {
unsigned k = R->getKind();		unsigned k = R->getKind();
return k >= BEGIN_DECL_REGIONS && k <= END_DECL_REGIONS;		return k >= BEGIN_DECL_REGIONS && k <= END_DECL_REGIONS;
}		}
};		};

▲ Show 20 Lines • Show All 513 Lines • Show Last 20 Lines