Page MenuHomePhabricator

Make TargetInstrInfo::isCopyInstr return true for regular COPY-instructions
ClosedPublic

Authored by aivchenk on Jul 27 2018, 6:06 AM.

Details

Summary

..Move all target-dependent checks into new isCopyInstrImpl method.

This change allows us to treat MoveReg-type instructions and generic
COPY instruction in the same way

Diff Detail

Repository
rL LLVM

Event Timeline

aivchenk created this revision.Jul 27 2018, 6:06 AM
qcolombet accepted this revision.Aug 6 2018, 4:38 PM

LGTM.
Nitpicks on the comments.

include/llvm/CodeGen/TargetInstrInfo.h
866 ↗(On Diff #157673)

The naming between the doxygen comment and the variable does not match (Source vs SourceOpNum).

lib/Target/ARM/ARMBaseInstrInfo.h
107 ↗(On Diff #157673)

Ditto.

This revision is now accepted and ready to land.Aug 6 2018, 4:38 PM
This revision was automatically updated to reflect the committed changes.