This is an archive of the discontinued LLVM Phabricator instance.

Differential D49904

[CMake] Disable -Wstringop-overflow
ClosedPublic

Authored by Hahnfeld on Jul 26 2018, 11:46 PM.

Details

Reviewers
AndreyChurbanov
jlpeyton
Commits
rGf985f9812847: [CMake] Disable -Wstringop-overflow
rOMP338283: [CMake] Disable -Wstringop-overflow
rL338283: [CMake] Disable -Wstringop-overflow
Summary

GCC 8 produces false-positives with this:

In file included from <openmp>/src/runtime/src/kmp_os.h:950,
                 from <openmp>/src/runtime/src/kmp.h:78,
                 from <openmp>/src/runtime/src/kmp_environment.cpp:54:
<openmp>/src/runtime/src/kmp_environment.cpp: In function ‘char* __kmp_env_get(const char*)’:
<openmp>/src/runtime/src/kmp_safe_c_api.h:52:50: warning: ‘char* strncpy(char*, const char*, size_t)’ specified bound depends on the length of the source argument [-Wstringop-overflow=]
 #define KMP_STRNCPY_S(dst, bsz, src, cnt) strncpy(dst, src, cnt)
                                           ~~~~~~~^~~~~~~~~~~~~~~
<openmp>/src/runtime/src/kmp_environment.cpp:97:5: note: in expansion of macro ‘KMP_STRNCPY_S’
     KMP_STRNCPY_S(result, len, value, len);
     ^~~~~~~~~~~~~
<openmp>/src/runtime/src/kmp_environment.cpp:92:28: note: length computed here
     size_t len = KMP_STRLEN(value) + 1;

This is stupid because result is allocated with KMP_INTERNAL_MALLOC(len),
so the arguments are correct.

Diff Detail

Repository
rOMP OpenMP

Event Timeline

Hahnfeld created this revision.Jul 26 2018, 11:46 PM
Herald added subscribers: openmp-commits, mgorny. · View Herald TranscriptJul 26 2018, 11:46 PM
jlpeyton accepted this revision.Jul 30 2018, 10:53 AM

LGTM

This revision is now accepted and ready to land.Jul 30 2018, 10:53 AM
Closed by commit rL338283: [CMake] Disable -Wstringop-overflow (authored by Hahnfeld). · Explain WhyJul 30 2018, 11:16 AM
Closed by commit rOMP338283: [CMake] Disable -Wstringop-overflow (authored by Hahnfeld). · Explain Why
This revision was automatically updated to reflect the committed changes.
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJul 30 2018, 11:16 AM
xbolva00 added a subscriber: xbolva00.Jul 30 2018, 11:17 AM

Can you turn off -Woverloaded-virtual for GCC? There are warnings during the build, which are not relevant (according to the person who commited the change which caused this warning with GCC, I asked him to check it some time ago)

Hahnfeld added a comment.Jul 30 2018, 11:25 AM
In D49904#1180626, @xbolva00 wrote:

Can you turn off -Woverloaded-virtual for GCC? There are warnings during the build, which are not relevant (according to the person who commited the change which caused this warning with GCC, I asked him to check it some time ago)

I'm not seeing any of these for libomp which this change is for. AFAICS there are no virtual methods in the OpenMP runtime, are you maybe talking about LLVM?

xbolva00 added a comment.Jul 30 2018, 11:37 AM
In D49904#1180637, @Hahnfeld wrote:
In D49904#1180626, @xbolva00 wrote:

Can you turn off -Woverloaded-virtual for GCC? There are warnings during the build, which are not relevant (according to the person who commited the change which caused this warning with GCC, I asked him to check it some time ago)

I'm not seeing any of these for libomp which this change is for. AFAICS there are no virtual methods in the OpenMP runtime, are you maybe talking about LLVM?

Yes, LLVM

Hahnfeld added a comment.Jul 30 2018, 11:39 AM
In D49904#1180661, @xbolva00 wrote:
In D49904#1180637, @Hahnfeld wrote:
In D49904#1180626, @xbolva00 wrote:

Can you turn off -Woverloaded-virtual for GCC? There are warnings during the build, which are not relevant (according to the person who commited the change which caused this warning with GCC, I asked him to check it some time ago)

I'm not seeing any of these for libomp which this change is for. AFAICS there are no virtual methods in the OpenMP runtime, are you maybe talking about LLVM?

Yes, LLVM

In that case you'll submit a change to the LLVM build system, this patch is only about the OpenMP runtime.

Revision Contents

PathSize
runtime/
cmake/
1 line
1 line

Diff 158020

runtime/cmake/LibompHandleFlags.cmake

Show All 38 Linesfunction(libomp_get_c_and_cxxflags_common flags)
libomp_append(flags_local -Wno-gnu-anonymous-struct LIBOMP_HAVE_WNO_GNU_ANONYMOUS_STRUCT_FLAG) libomp_append(flags_local -Wno-gnu-anonymous-struct LIBOMP_HAVE_WNO_GNU_ANONYMOUS_STRUCT_FLAG)
libomp_append(flags_local -Wno-unknown-pragmas LIBOMP_HAVE_WNO_UNKNOWN_PRAGMAS_FLAG) libomp_append(flags_local -Wno-unknown-pragmas LIBOMP_HAVE_WNO_UNKNOWN_PRAGMAS_FLAG)
libomp_append(flags_local -Wno-missing-field-initializers LIBOMP_HAVE_WNO_MISSING_FIELD_INITIALIZERS_FLAG) libomp_append(flags_local -Wno-missing-field-initializers LIBOMP_HAVE_WNO_MISSING_FIELD_INITIALIZERS_FLAG)
libomp_append(flags_local -Wno-missing-braces LIBOMP_HAVE_WNO_MISSING_BRACES_FLAG) libomp_append(flags_local -Wno-missing-braces LIBOMP_HAVE_WNO_MISSING_BRACES_FLAG)
libomp_append(flags_local -Wno-comment LIBOMP_HAVE_WNO_COMMENT_FLAG) libomp_append(flags_local -Wno-comment LIBOMP_HAVE_WNO_COMMENT_FLAG)
libomp_append(flags_local -Wno-self-assign LIBOMP_HAVE_WNO_SELF_ASSIGN_FLAG) libomp_append(flags_local -Wno-self-assign LIBOMP_HAVE_WNO_SELF_ASSIGN_FLAG)
libomp_append(flags_local -Wno-vla-extension LIBOMP_HAVE_WNO_VLA_EXTENSION_FLAG) libomp_append(flags_local -Wno-vla-extension LIBOMP_HAVE_WNO_VLA_EXTENSION_FLAG)
libomp_append(flags_local -Wno-format-pedantic LIBOMP_HAVE_WNO_FORMAT_PEDANTIC_FLAG) libomp_append(flags_local -Wno-format-pedantic LIBOMP_HAVE_WNO_FORMAT_PEDANTIC_FLAG)
libomp_append(flags_local -Wstringop-overflow=0 LIBOMP_HAVE_WSTRINGOP_OVERFLOW_FLAG)
libomp_append(flags_local /GS LIBOMP_HAVE_GS_FLAG) libomp_append(flags_local /GS LIBOMP_HAVE_GS_FLAG)
libomp_append(flags_local /EHsc LIBOMP_HAVE_EHSC_FLAG) libomp_append(flags_local /EHsc LIBOMP_HAVE_EHSC_FLAG)
libomp_append(flags_local /Oy- LIBOMP_HAVE_OY__FLAG) libomp_append(flags_local /Oy- LIBOMP_HAVE_OY__FLAG)
# Intel(R) C Compiler flags # Intel(R) C Compiler flags
libomp_append(flags_local /Qsafeseh LIBOMP_HAVE_QSAFESEH_FLAG) libomp_append(flags_local /Qsafeseh LIBOMP_HAVE_QSAFESEH_FLAG)
libomp_append(flags_local -Qoption,cpp,--extended_float_types LIBOMP_HAVE_EXTENDED_FLOAT_TYPES_FLAG) libomp_append(flags_local -Qoption,cpp,--extended_float_types LIBOMP_HAVE_EXTENDED_FLOAT_TYPES_FLAG)
libomp_append(flags_local -Qlong_double LIBOMP_HAVE_LONG_DOUBLE_FLAG) libomp_append(flags_local -Qlong_double LIBOMP_HAVE_LONG_DOUBLE_FLAG)
libomp_append(flags_local -Qdiag-disable:177 LIBOMP_HAVE_DIAG_DISABLE_177_FLAG) libomp_append(flags_local -Qdiag-disable:177 LIBOMP_HAVE_DIAG_DISABLE_177_FLAG)
▲ Show 20 Lines • Show All 153 Lines • Show Last 20 Lines

runtime/cmake/config-ix.cmake

Show First 20 Lines • Show All 60 Lines • ▼ Show 20 Lines
check_c_compiler_flag(-Wgnu-anonymous-struct LIBOMP_HAVE_WNO_GNU_ANONYMOUS_STRUCT_FLAG) check_c_compiler_flag(-Wgnu-anonymous-struct LIBOMP_HAVE_WNO_GNU_ANONYMOUS_STRUCT_FLAG)
check_c_compiler_flag(-Wunknown-pragmas LIBOMP_HAVE_WNO_UNKNOWN_PRAGMAS_FLAG) check_c_compiler_flag(-Wunknown-pragmas LIBOMP_HAVE_WNO_UNKNOWN_PRAGMAS_FLAG)
check_c_compiler_flag(-Wmissing-field-initializers LIBOMP_HAVE_WNO_MISSING_FIELD_INITIALIZERS_FLAG) check_c_compiler_flag(-Wmissing-field-initializers LIBOMP_HAVE_WNO_MISSING_FIELD_INITIALIZERS_FLAG)
check_c_compiler_flag(-Wmissing-braces LIBOMP_HAVE_WNO_MISSING_BRACES_FLAG) check_c_compiler_flag(-Wmissing-braces LIBOMP_HAVE_WNO_MISSING_BRACES_FLAG)
check_c_compiler_flag(-Wcomment LIBOMP_HAVE_WNO_COMMENT_FLAG) check_c_compiler_flag(-Wcomment LIBOMP_HAVE_WNO_COMMENT_FLAG)
check_c_compiler_flag(-Wself-assign LIBOMP_HAVE_WNO_SELF_ASSIGN_FLAG) check_c_compiler_flag(-Wself-assign LIBOMP_HAVE_WNO_SELF_ASSIGN_FLAG)
check_c_compiler_flag(-Wvla-extension LIBOMP_HAVE_WNO_VLA_EXTENSION_FLAG) check_c_compiler_flag(-Wvla-extension LIBOMP_HAVE_WNO_VLA_EXTENSION_FLAG)
check_c_compiler_flag(-Wformat-pedantic LIBOMP_HAVE_WNO_FORMAT_PEDANTIC_FLAG) check_c_compiler_flag(-Wformat-pedantic LIBOMP_HAVE_WNO_FORMAT_PEDANTIC_FLAG)
check_c_compiler_flag(-Wstringop-overflow=0 LIBOMP_HAVE_WSTRINGOP_OVERFLOW_FLAG)
check_c_compiler_flag(-msse2 LIBOMP_HAVE_MSSE2_FLAG) check_c_compiler_flag(-msse2 LIBOMP_HAVE_MSSE2_FLAG)
check_c_compiler_flag(-ftls-model=initial-exec LIBOMP_HAVE_FTLS_MODEL_FLAG) check_c_compiler_flag(-ftls-model=initial-exec LIBOMP_HAVE_FTLS_MODEL_FLAG)
libomp_check_architecture_flag(-mmic LIBOMP_HAVE_MMIC_FLAG) libomp_check_architecture_flag(-mmic LIBOMP_HAVE_MMIC_FLAG)
libomp_check_architecture_flag(-m32 LIBOMP_HAVE_M32_FLAG) libomp_check_architecture_flag(-m32 LIBOMP_HAVE_M32_FLAG)
if(WIN32) if(WIN32)
# Check Windows MSVC style flags. # Check Windows MSVC style flags.
check_c_compiler_flag(/TP LIBOMP_HAVE_TP_FLAG) check_c_compiler_flag(/TP LIBOMP_HAVE_TP_FLAG)
check_cxx_compiler_flag(/EHsc LIBOMP_HAVE_EHSC_FLAG) check_cxx_compiler_flag(/EHsc LIBOMP_HAVE_EHSC_FLAG)
▲ Show 20 Lines • Show All 204 Lines • Show Last 20 Lines