This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Add clamp bit to dot intrinsics
ClosedPublic

Authored by kzhuravl on Jul 26 2018, 2:12 PM.

Diff Detail

Event Timeline

kzhuravl created this revision.Jul 26 2018, 2:12 PM
arsenm added inline comments.Jul 27 2018, 2:03 AM
lib/Target/AMDGPU/SIISelLowering.cpp
7550

should be getTargetConstant. Is there any reason we also can't match clamp here?

kzhuravl updated this revision to Diff 158067.Jul 30 2018, 2:16 PM

Address review feedback.

lib/Target/AMDGPU/SIISelLowering.cpp
7550

should be getTargetConstant

Done.

Is there any reason we also can't match clamp here?

This goes out of scope of the ticket. Can this be done in a separate change?

This revision is now accepted and ready to land.Jul 31 2018, 9:43 AM
This revision was automatically updated to reflect the committed changes.