Page MenuHomePhabricator

AMDGPU: Conversions always produce canonical results
ClosedPublic

Authored by arsenm on Jul 26 2018, 4:29 AM.

Details

Summary

Not sure why this was checking for denormals for f16.
My interpretation of the IEEE standard is conversions
should produce a canonical result, and the ISA manual
says denormals are created when appropriate.

Diff Detail

Event Timeline

arsenm created this revision.Jul 26 2018, 4:29 AM
rampitec accepted this revision.Jul 26 2018, 12:05 PM

I think this is right about round and extend.

This revision is now accepted and ready to land.Jul 26 2018, 12:05 PM
arsenm closed this revision.Aug 6 2018, 2:52 PM

r339064

You know you can state "Differential Revision:
https://reviews.llvm.org/D<number>"
and the phab will properly automatically close it for you?

(You could use arc patch or something to get that line automatically)

arsenm added a comment.Aug 6 2018, 3:12 PM

You know you can state "Differential Revision:
https://reviews.llvm.org/D<number>"
and the phab will properly automatically close it for you?

(You could use arc patch or something to get that line automatically)

I gave up on using arc. The way it wants to deal with multiple patches at a time makes no sense