This is an archive of the discontinued LLVM Phabricator instance.

[ELF] Use search paths for --version-script=
ClosedPublic

Authored by MaskRay on Jul 25 2018, 2:02 PM.

Event Timeline

MaskRay created this revision.Jul 25 2018, 2:02 PM
ruiu accepted this revision.Jul 25 2018, 2:46 PM

LGTM

test/ELF/version-script-in-search-path.s
9

For safety, you should use %T/searchpath/%t.script instead of %T/searchpath/t.script because this line can succeed if there's other test that happens to create t.script in the current directory.

This revision is now accepted and ready to land.Jul 25 2018, 2:46 PM
This revision was automatically updated to reflect the committed changes.
ruiu added a subscriber: MaskRay.Jul 25 2018, 2:58 PM

Looks like you forgot to apply the change that I proposed.

MaskRay added inline comments.Jul 25 2018, 3:00 PM
test/ELF/version-script-in-search-path.s
9

Sorry I didn't notice this comment when committing.

%t.script is an absolute path so it does not work here --version-script=%t.script

ruiu added a comment.Jul 25 2018, 3:02 PM

You could use %basename_t. I did it in r337972 for you.

You could use %basename_t. I did it in r337972 for you.

Thanks! And good to know this substitution (defined in utils/lit/lit/TestRunner.py). I did the same for test/ELF/linkerscript/linker-script-in-search-path.s