This is an archive of the discontinued LLVM Phabricator instance.

[clang:sema] de-duplicate getDepthAndIndex helpers
ClosedPublic

Authored by nickdesaulniers on Jul 24 2018, 2:31 PM.

Diff Detail

Event Timeline

vsk added a comment.Jul 24 2018, 2:37 PM

Thanks for doing this!

include/clang/Sema/SemaInternal.h
120

Perhaps 'const auto *TTP = ...' would read better here, given that the expected type appears once already in the r.h.s of the expression? I have the same comment re: the three other casts above.

  • prefer auto when type is specified on RHS of assignment.
nickdesaulniers marked an inline comment as done.Jul 24 2018, 2:48 PM

Thanks for the review. Today is my first day committing to clang!

vsk accepted this revision.Jul 24 2018, 3:00 PM

Thanks for the review. Today is my first day committing to clang!

Welcome :).

LGTM. Feel free to commit this yourself once you obtain commit access (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access). I'd also be happy to commit this on your behalf.

This revision is now accepted and ready to land.Jul 24 2018, 3:00 PM
This revision was automatically updated to reflect the committed changes.