This is an archive of the discontinued LLVM Phabricator instance.

[Dominators] Remove the DeferredDominance class
ClosedPublic

Authored by NutshellySima on Jul 24 2018, 11:48 AM.

Details

Summary

After converting all existing passes to use the new DomTreeUpdater interface, there isn't any usage of the original DeferredDominance class. Thus, we can safely remove it from the codebase.

Diff Detail

Repository
rL LLVM

Event Timeline

NutshellySima created this revision.Jul 24 2018, 11:48 AM
kuhar accepted this revision.Aug 2 2018, 8:42 AM

Nit: It's removal and not deprecation.
Looks good otherwise.

This revision is now accepted and ready to land.Aug 2 2018, 8:42 AM
NutshellySima retitled this revision from [Dominators] Deprecate the DeferredDominance class to [Dominators] Remove the DeferredDominance class.Aug 2 2018, 8:44 AM
brzycki accepted this revision.Aug 2 2018, 10:42 AM

LGTM. DTU should be the only way to do Lazy or Eager updates to DT.

This revision was automatically updated to reflect the committed changes.
llvm/trunk/lib/IR/Dominators.cpp