This is an archive of the discontinued LLVM Phabricator instance.

[RegisterBankInfo] Ignore InstrMappings that create impossible to repair operands
ClosedPublic

Authored by tstellar on Jul 24 2018, 8:10 AM.

Details

Summary

This is a follow-up to r303043. In computeMapping(), we need to disqualify an
InstrMapping if it would be impossible to repair one of the registers in the
instruction to match the mapping.

This change is needed in order to be able to define an instruction
mapping for G_SELECT for the AMDGPU target and will be tested
by test/CodeGen/AMDGPU/GlobalISel/regbankselect-select.mir

Diff Detail

Repository
rL LLVM

Event Timeline

tstellar created this revision.Jul 24 2018, 8:10 AM
qcolombet accepted this revision.Jul 24 2018, 11:56 AM

Silly me for not catching this during the first review.

LGTM!

This revision is now accepted and ready to land.Jul 24 2018, 11:56 AM
This revision was automatically updated to reflect the committed changes.