Currently, support for debug_types is only present for ELF and trying to pass -fdebug-types-section for other targets results in a crash in the backend. Until this is fixed, we should emit a diagnostic in the front end when the option is passed for non-linux targets.
Details
Details
- Reviewers
labath dblaikie probinson - Commits
- rG488bd0159bf1: [DebugInfo] Error out when enabling -fdebug-types-section on non-ELF target.
rC337717: [DebugInfo] Error out when enabling -fdebug-types-section on non-ELF target.
rL337717: [DebugInfo] Error out when enabling -fdebug-types-section on non-ELF target.
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
I believe debug_types is used on non-linux targets as well. Judging by the other review all ELF targets should at least have a chance of working, so maybe key the error off of that?
Comment Actions
Thanks, I meant to use isOSBinFormatELF but I think it got lost in an accidental undo. The test didn't capture that because it's using a linux target triple.
Comment Actions
Is this because type units depend on COMDAT support? I had a vague idea that COFF also supports COMDAT.
Comment Actions
It's more that I want to reflect the current situation and prevent MC from crashing while we come up with a solution. This was very little work and we can always revert it once things are fixed.