Page MenuHomePhabricator

[CMake] Don't use CLANG_DEFAULT_* values
ClosedPublic

Authored by phosek on Jul 12 2018, 4:05 PM.

Details

Summary

These are not necessarily correct, just because Clang is configured
to use libc++ or compiler-rt as defaults doesn't mean that the host
compiler uses these as defaults as well. A more correct solution
would be to test the host compiler to check what the default actually
is as attempted in D46857.

PR-38025

Diff Detail

Event Timeline

phosek created this revision.Jul 12 2018, 4:05 PM
Herald added subscribers: Restricted Project, llvm-commits, mgorny. · View Herald TranscriptJul 12 2018, 4:05 PM

Thanks Petr, I can confirm that this fixed the compiler-rt build issues in Chrome OS builds.

morehouse accepted this revision.Jul 13 2018, 8:35 AM
This revision is now accepted and ready to land.Jul 13 2018, 8:35 AM
This revision was automatically updated to reflect the committed changes.