This is an archive of the discontinued LLVM Phabricator instance.

[libFuzzer] Disable dataflow.test on AArch64.
ClosedPublic

Authored by morehouse on Jul 10 2018, 12:49 PM.

Details

Summary

After my recent change to allow MSan + libFuzzer, the
ExplodeDFSanLabelsTest.cpp test started to overflow the stack with
recursive function SetBytesForLabel() on an AArch64 bot. Perhaps that
bot has a smaller stack size, or maybe AArch64 has larger stack frames
for this particular function.

Event Timeline

morehouse created this revision.Jul 10 2018, 12:49 PM

@kcc: Do we want to just disable this test for AArch64, or should we change SetBytesForLabel to not be recursive?

Note that I can reproduce this locally by compiling with -O0.

kcc accepted this revision.Jul 10 2018, 1:09 PM

It it bothers someone, we can turn this function into a non-recursive by implementing a fixed-size queue (array of 2^16 shorts).
Or you can run the ExplodeDFSanLabelsTestDF with a large value of "ulimit -s".

It's fine for me to just disable this test on non-linux-x86_64

This revision is now accepted and ready to land.Jul 10 2018, 1:09 PM
This revision was automatically updated to reflect the committed changes.