This is an archive of the discontinued LLVM Phabricator instance.

Set Symbol::IsUsedInRegularObj in a consistent manor between COFF, ELF and wasm. NFC
ClosedPublic

Authored by sbc100 on Jul 10 2018, 10:23 AM.

Event Timeline

sbc100 created this revision.Jul 10 2018, 10:23 AM
sbc100 retitled this revision from Set IsUsedInRegularObj in a consistent manor between COFF, ELF and wasm. NFC to Set Symbol::IsUsedInRegularObj in a consistent manor between COFF, ELF and wasm. NFC.Jul 10 2018, 10:24 AM
sbc100 edited the summary of this revision. (Show Details)
sbc100 added a reviewer: ruiu.
sbc100 updated this revision to Diff 156905.Jul 23 2018, 3:43 PM
  • revert change to wasm addLazy
ruiu added inline comments.Jul 23 2018, 4:24 PM
COFF/SymbolTable.h
111

Can you remove these single parameter version of insert by explicitly passing nullptr if the number of calls of that version is not too many?

sbc100 updated this revision to Diff 156930.Jul 23 2018, 5:09 PM
sbc100 marked an inline comment as done.
  • remove overload
ruiu accepted this revision.Aug 2 2018, 1:10 PM

LGTM

This revision is now accepted and ready to land.Aug 2 2018, 1:10 PM
This revision was automatically updated to reflect the committed changes.