This is an archive of the discontinued LLVM Phabricator instance.

Differential D49115

Add lowercase OS name feature
ClosedPublic

Authored by vlad.tsyrklevich on Jul 9 2018, 6:00 PM.

Details

Reviewers
pcc
eugenis
Commits
rG25291f15e725: Add lowercase OS name feature
rCRT336633: Add lowercase OS name feature
rL336633: Add lowercase OS name feature
Summary

Some tests already make use of OS feature names, e.g. 'linux' and 'freebsd',
but they are not actually currently set by lit.

Diff Detail

Event Timeline

vlad.tsyrklevich created this revision.Jul 9 2018, 6:00 PM
Herald added subscribers: Restricted Project, llvm-commits, delcypher and 2 others. · View Herald TranscriptJul 9 2018, 6:00 PM
Harbormaster completed remote builds in B20190: Diff 154744.Jul 9 2018, 6:00 PM
eugenis accepted this revision.Jul 9 2018, 6:04 PM
This revision is now accepted and ready to land.Jul 9 2018, 6:04 PM
Closed by commit rL336633: Add lowercase OS name feature (authored by vlad.tsyrklevich). · Explain WhyJul 9 2018, 7:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
4 lines

Diff 154744

test/lit.common.cfg

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines
path = os.path.pathsep.join((config.llvm_tools_dir, config.environment['PATH'])) path = os.path.pathsep.join((config.llvm_tools_dir, config.environment['PATH']))
config.environment['PATH'] = path config.environment['PATH'] = path
# Help MSVS link.exe find the standard libraries. # Help MSVS link.exe find the standard libraries.
# Make sure we only try to use it when targetting Windows. # Make sure we only try to use it when targetting Windows.
if platform.system() == 'Windows' and '-win' in config.target_triple: if platform.system() == 'Windows' and '-win' in config.target_triple:
config.environment['LIB'] = os.environ['LIB'] config.environment['LIB'] = os.environ['LIB']
config.available_features.add(config.host_os.lower())
if re.match(r'^x86_64.*-linux', config.target_triple): if re.match(r'^x86_64.*-linux', config.target_triple):
config.available_features.add("x86_64-linux") config.available_features.add("x86_64-linux")
# Use ugly construction to explicitly prohibit "clang", "clang++" etc. # Use ugly construction to explicitly prohibit "clang", "clang++" etc.
# in RUN lines. # in RUN lines.
config.substitutions.append( config.substitutions.append(
(' clang', """\n\n*** Do not use 'clangXXX' in tests, (' clang', """\n\n*** Do not use 'clangXXX' in tests,
instead define '%clangXXX' substitution in lit config. ***\n\n""") ) instead define '%clangXXX' substitution in lit config. ***\n\n""") )
# Allow tests to be executed on a simulator or remotely. # Allow tests to be executed on a simulator or remotely.
▲ Show 20 Lines • Show All 314 Lines • Show Last 20 Lines