This is an archive of the discontinued LLVM Phabricator instance.

Differential D48995

[ORC] Add BitReader/BitWriter to target_link_libraries
ClosedPublic

Authored by aheejin on Jul 5 2018, 1:45 PM.

Details

Reviewers
lhames
lebedev.ri
Commits
rGe69ba6e6d56c: [ORC] Add BitReader/BitWriter to target_link_libraries
rL336389: [ORC] Add BitReader/BitWriter to target_link_libraries
Summary

CompileOnDemandLayer.cpp uses function in these libraries, and builds
with -DSHARED_LIB=ON fail without this.

Diff Detail

Event Timeline

aheejin created this revision.Jul 5 2018, 1:45 PM
Harbormaster completed remote builds in B20076: Diff 154306.Jul 5 2018, 1:45 PM
Herald added subscribers: llvm-commits, mgorny. · View Herald TranscriptJul 5 2018, 1:45 PM
lebedev.ri accepted this revision.Jul 5 2018, 2:06 PM
lebedev.ri added a subscriber: lebedev.ri.

We really should have a bot to catch those :)
Since the last commit to lib/ExecutionEngine/Orc/ (rL336385) added those includes, this is probably correct.
Please commit now.

This revision is now accepted and ready to land.Jul 5 2018, 2:06 PM
Closed by commit rL336389: [ORC] Add BitReader/BitWriter to target_link_libraries (authored by aheejin). · Explain WhyJul 5 2018, 2:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
ExecutionEngine/
Orc/
6 lines

Diff 154306

lib/ExecutionEngine/Orc/CMakeLists.txt

Show All 17 Linesadd_llvm_library(LLVMOrcJIT
RTDyldObjectLinkingLayer.cpp RTDyldObjectLinkingLayer.cpp
ADDITIONAL_HEADER_DIRS ADDITIONAL_HEADER_DIRS
${LLVM_MAIN_INCLUDE_DIR}/llvm/ExecutionEngine/Orc ${LLVM_MAIN_INCLUDE_DIR}/llvm/ExecutionEngine/Orc
DEPENDS DEPENDS
intrinsics_gen intrinsics_gen
) )
target_link_libraries(LLVMOrcJIT
PRIVATE
LLVMBitReader
LLVMBitWriter
)